Don't die on malformed json in the extras field. Give feedback to user (

#338)
apache · Apr 13, 2016 · 8fe5790 · 8fe5790
1 parent 1e08b3e
commit 8fe5790
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/caravel/templates/caravel/models/database/macros.html b/caravel/templates/caravel/models/database/macros.html
@@ -2,12 +2,22 @@
   <script>
     $("#sqlalchemy_uri").parent()
       .append('<button id="testconn" class="btn">Test Connection</button>');
-    $("#testconn").click(function() {
+    $("#testconn").click(function(e) {
+      e.preventDefault();
       var url = "/caravel/testconn";
+
+      var data = {};
+      try{
+        data = JSON.stringify({ uri: $("#sqlalchemy_uri").val(), extras: JSON.parse($("#extra").val()) })
+      } catch(parse_error){
+        alert("Malformed JSON in the extras field: " + parse_error);
+        return false
+      }
+
       $.ajax({
         method: "POST",
         url: url,
-        data: JSON.stringify({ uri: $("#sqlalchemy_uri").val(), extras: JSON.parse($("#extra").val()) }),
+        data: data,
         dataType: 'json',
         contentType: "application/json; charset=utf-8"
       }).done(function(data) {

diff --git a/caravel/views.py b/caravel/views.py
@@ -638,7 +638,7 @@ def testconn(self):
         """Tests a sqla connection"""
         try:
             uri = request.json.get('uri')
-            connect_args = request.json.get('extras', {}).get('engine_params', {}).get('connect_args')
+            connect_args = request.json.get('extras', {}).get('engine_params', {}).get('connect_args', {})
             engine = create_engine(uri, connect_args=connect_args)
             engine.connect()
             return json.dumps(engine.table_names(), indent=4)