Skip to content

Commit

Permalink
Change the size of the column datasource_name in datasource creation … (
Browse files Browse the repository at this point in the history
#345)

* Change the size of the column datasource_name in datasource creation table to fix a Sql server specific issue.

* Change the model according to the change of the database script done in the PR 345
  • Loading branch information
ludzzz authored and mistercrunch committed Apr 14, 2016
1 parent 91a3594 commit eb5a417
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion caravel/migrations/versions/4e6a06bad7a8_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def upgrade():
sa.Column('created_on', sa.DateTime(), nullable=False),
sa.Column('changed_on', sa.DateTime(), nullable=False),
sa.Column('id', sa.Integer(), nullable=False),
sa.Column('datasource_name', sa.String(length=250), nullable=True),
sa.Column('datasource_name', sa.String(length=256), nullable=True),
sa.Column('is_featured', sa.Boolean(), nullable=True),
sa.Column('is_hidden', sa.Boolean(), nullable=True),
sa.Column('description', sa.Text(), nullable=True),
Expand Down
2 changes: 1 addition & 1 deletion caravel/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ class DruidDatasource(Model, AuditMixinNullable, Queryable):

__tablename__ = 'datasources'
id = Column(Integer, primary_key=True)
datasource_name = Column(String(250), unique=True)
datasource_name = Column(String(256), unique=True)
is_featured = Column(Boolean, default=False)
is_hidden = Column(Boolean, default=False)
description = Column(Text)
Expand Down

0 comments on commit eb5a417

Please sign in to comment.