Fix for 2-axis charts where it shrinks them a little bit #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ function viz_nvd3(slice) { | |||
| nv.addGraph(function() { | |||
| if (viz_type === 'line') { | |||
| if (viz.form_data.show_brush) { | |||
| chart = nv.models.lineWithFocusChart() | |||
| chart = nv.models.lineWithFocusChart(); | |||
| //chart.lines2.xScale( d3.time.scale.utc()); | |||
| chart.lines2.xScale(d3.time.scale.utc()); | |||
There was a problem hiding this comment.
I think indent is (was) busted here...
There was a problem hiding this comment.
fixed the indentation on the few rows below.
mistercrunch
added a commit
that referenced
this pull request
Jan 8, 2016
…rescaling_to_nvd3_file Fix for 2-axis charts where it shrinks them a little bit
hughhhh
referenced
this pull request
in lyft/incubator-superset
Apr 1, 2018
@hughhhh @betodealmeida Updated https://confluence.lyft.net/display/ENG/Superset+Runbook to reflect the rebase and new cherry.
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Aug 31, 2018
Cherry-picks: Allow users to choose color for BigNumber
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
This was referenced Sep 27, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the fix for charts with 2 x-axes. It scales it down 30 which makes it fit.