Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPMification & Reactification #139

Merged
merged 25 commits into from
Feb 28, 2016
Merged

NPMification & Reactification #139

merged 25 commits into from
Feb 28, 2016

Conversation

mistercrunch
Copy link
Member

@williaster , I'm creating the PR!

williaster and others added 3 commits February 19, 2016 11:39
@williaster
Add npm package.json and setup webpack to transpile ES6/JSX and compi…
f40c024 
…le JS files for frontend refactor. See readme.md in assets/ for npm setup instructions and visit the panoramix home page for a React sandbox.
Update readme.md
0eb3dcd
@williaster
partial refactor of explore page, visualizations not managed with web…
af34549 
…pack yet.
@mistercrunch
Copy link
Member Author

Notes:

  • I was able to install and get up and running without problems!
  • many files have just been mved and should have been git mved to carry history and make a smaller PR, I think it's work fixing
  • I like the new theme, though we should use matching Airbnb colors so that it doesn't clash as much with charts, maybe we can just pick the colors closer to the theme's in the Airbnb rainbow
  • Some templates are unafected by the theme changes, I'll look into it as a way to get familiar with the changes

@mistercrunch
Copy link
Member Author

oh and looks like some of your commits aren't attached to your github id

@williaster
huge npm refactor of all visualizations. table views are broken due t…
79e6fc9 
…o broken shimming for jquery/jquery-ui, dashboards are broken due to refactor of explore views.
@williaster
Copy link
Contributor

woot! let's hold off on merging this until the npm-ification is complete / dashboard + explore are back to working.

  • I agree re the airbnb colors, maybe we can play with a few in person. I have a customizable bootstrap repo locally we can modify / update from.
  • thanks re github id, I think it's an issue with my ghe account
  • we discussed theme mismatches + git mvs in person

I'll look into merging your PR now

mistercrunch and others added 21 commits February 23, 2016 17:48
@mistercrunch
A simple base template for npm
f5e0ed7
@mistercrunch
Fixing 2 links
d582efe
@mistercrunch
Merge pull request #141 from mistercrunch/npm
dbb9f66 
A simple base template for npm
@mistercrunch
A few cosmetic fixes (nvd3 tooltips, buttons, tables)
9552d09
@mistercrunch
Adjustments based on comment
df8ea52
@mistercrunch
Merge pull request #142 from mistercrunch/npm
71073d8 
A few cosmetic fixes (nvd3 tooltips, buttons, tables)
@williaster
Remove base.entry.js, declare all JS dependencies in explore using np…
3e83460 
…m. Pin older select2 version to enable select2Sortable.
@mistercrunch
Moving files around
171301b
@mistercrunch
NPMify sql.html
e70542d
@williaster
Merge pull request #145 from mistercrunch/npm
71b1111 
Moving files around ... yay!
@mistercrunch
Tackling Featured Datasets
8dcd5e0
@mistercrunch
Fixing table and pivot_table
d8409c1
@mistercrunch
Fixing dashboard.html
e4e7b91
@mistercrunch
Adding missing fonts
70e1aa3
@mistercrunch
Cleaning up assets/vendors
fd0e680
@mistercrunch
npmify datamaps dependency
c929b2a
@mistercrunch
Moving html assets back to flask template folder
4f4c67c
@mistercrunch
Moving content of assets/readme.md to contributing.md
c304cc4
@mistercrunch
Removing js_files and css_files entries from viz.py
58c7b8c
@mistercrunch
Rolling back to previous theme until we polish bootswarch.paper
bc41820
@mistercrunch
Merge pull request #147 from mistercrunch/npm
d40664b 
Tackling Featured Datasets
mistercrunch added a commit that referenced this pull request Feb 28, 2016
@mistercrunch
Merge pull request #139 from mistercrunch/chris/npm-ify2
63b4f56 
NPMification & Reactification
@mistercrunch mistercrunch merged commit 63b4f56 into master Feb 28, 2016
@mistercrunch mistercrunch deleted the chris/npm-ify2 branch February 28, 2016 23:19
hughhhh added a commit to lyft/incubator-superset that referenced this pull request Apr 1, 2018
@hughhhh @lyft-buildnotify-3
Change cache to last for 7 days (apache#139)
7c3253e 
Moving the to 3 days -> 84% cache hit
Hoping 7 days will put us in the 90% 

https://grafana-staging.lyft.net/dashboard/db/superset-stats?orgId=1&from=1519591954615&to=1519694727504

@mistercrunch @betodealmeida
etr2460 pushed a commit to graceguo-supercat/superset that referenced this pull request Jul 11, 2019
Merge pull request apache#139 from john-bodley/john-bodley--cherry-pi…
4ccd35e 
…ck-7573

[ad-hoc] Fixing type for count distinct (apache#7573)
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
@kristw
feat: add chart companion components (apache#139)
a82faec 
* feat: add chart companion components

* test: add more tests

* test: improve coverage

* test: fix failed test

* test: mock ResizeObserver

* fix: test coverage

* test: fix set dimension

* feat: make keyColumn optional

* fix: address comments

* fix: test delay
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kristw @zhaoyongjie
feat: add chart companion components (apache#139)
37e3950 
* feat: add chart companion components

* test: add more tests

* test: improve coverage

* test: fix failed test

* test: mock ResizeObserver

* fix: test coverage

* test: fix set dimension

* feat: make keyColumn optional

* fix: address comments

* fix: test delay
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kristw @zhaoyongjie
feat: add chart companion components (apache#139)
260148e 
* feat: add chart companion components

* test: add more tests

* test: improve coverage

* test: fix failed test

* test: mock ResizeObserver

* fix: test coverage

* test: fix set dimension

* feat: make keyColumn optional

* fix: address comments

* fix: test delay
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kristw @zhaoyongjie
feat: add chart companion components (apache#139)
70c3ec8 
* feat: add chart companion components

* test: add more tests

* test: improve coverage

* test: fix failed test

* test: mock ResizeObserver

* fix: test coverage

* test: fix set dimension

* feat: make keyColumn optional

* fix: address comments

* fix: test delay
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kristw @zhaoyongjie
feat: add chart companion components (apache#139)
e5e09f9 
* feat: add chart companion components

* test: add more tests

* test: improve coverage

* test: fix failed test

* test: mock ResizeObserver

* fix: test coverage

* test: fix set dimension

* feat: make keyColumn optional

* fix: address comments

* fix: test delay
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @williaster