Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoxy sets allowBackup="true" #467

Closed
audax opened this issue Jul 10, 2018 · 3 comments
Closed

Epoxy sets allowBackup="true" #467

audax opened this issue Jul 10, 2018 · 3 comments

Comments

@audax
Copy link

audax commented Jul 10, 2018

See: https://github.com/airbnb/epoxy/search?q=allowBackup&unscoped_q=allowBackup

I don't see a good reason why Epoxy would need to set this attribute. To actually disable backups for my application, I had to set tools:replace="android:allowBackup" in my manifest.

@elihart
Copy link
Contributor

elihart commented Jul 10, 2018

Are you using the databinding module? It doesn't seem to be set for the main epoxy module.

I don't think I set this purposefully, and the only thing I can think of is that this is the default when using Android Studio's wizard to create a new module.

I think it should be fine if we remove it. Thanks for bringing it up

@audax
Copy link
Author

audax commented Jul 11, 2018

Yes, I am using the databinding module. The default for new modules is indeed true which is why I only noticed this after using epoxy for a while.

@elihart
Copy link
Contributor

elihart commented Jul 28, 2018

Fixed with #481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants