[eslint] remove id length rule (too much nutrage) #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed. We could still set "min" to |
justjake
added a commit
that referenced
this pull request
Nov 5, 2015
[eslint] remove id length rule (too much nutrage)
This was referenced Nov 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close: #567 #563, #510
It seems like everyone is nutraged about one letter variable names. I know I am. Let's just turn this rule off and forget we ever thought it was a good idea. If you find yourself having a problem with one-letter variable names on your team, you can easily re-enable this rule.
@ljharb @hshoff