[eslint] Enforce rule 18.5 #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rule 18.5 [1] states that files shall end with a single newline character. Until now, this was not checked because there was no such option in eslint. Since version 1.8.0, eslint provides the ability to do that. See pull request on eslint [2] for details on implementation and usage. Let's use it in airbnb eslint plugin now! [1]: https://github.com/airbnb/javascript#18.5 [2]: eslint/eslint#4266
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule 18.5 states that files shall end with a single newline
character. Until now, this was not checked because there was no such
option in eslint.
Since version 1.8.0, eslint provides the ability to do that. See pull
request on eslint for details on implementation and usage. Let's use
it in airbnb eslint plugin now!