Remove deprecated react/jsx-quotes #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, good call, totally forgot about that. thanks! |
ljharb
added a commit
that referenced
this pull request
Dec 15, 2015
[eslint config] [fix] Remove deprecated react/jsx-quotes
|
That should probably exist in the |
|
it's not from the react plugin, it's in core eslint - i suppose it could be moved there. |
|
Yeah, but the way I see it the jsx rules don't make sense to apply outside of our |
|
that's a fair point. a PR to move it over would be just fine, and wouldn't impact the module at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule is deprecated, but was reintroduced in #618. Running eslint with this config now prints:
The correct rule is already enforced here.