Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore URLs in max-len #664

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Ignore URLs in max-len #664

merged 1 commit into from
Jan 7, 2016

Conversation

silvenon
Copy link
Contributor

@silvenon silvenon commented Jan 7, 2016

How do you get around this situation?

// https://github.com/webpack/css-loader/tree/1298d2b38c4770dbf853ff1eed632fe239881cc2#css-modules
const foo = 'bar';

I could use a URL shortener, but that would remove the information from the URL.

@ljharb
Copy link
Collaborator

ljharb commented Jan 7, 2016

This seems legit. LGTM. I'll merge if other contributors agree.

@kesne
Copy link
Contributor

kesne commented Jan 7, 2016

I'm not a real contributor but this looks great to me.

goatslacker added a commit that referenced this pull request Jan 7, 2016
@goatslacker
Merge pull request #664 from silvenon/patch-1
e171f8a 
Ignore URLs in max-len
@goatslacker goatslacker merged commit e171f8a into airbnb:master Jan 7, 2016
@silvenon silvenon deleted the patch-1 branch January 7, 2016 01:04
@silvenon
Copy link
Contributor Author

silvenon commented Jan 7, 2016

Awesome ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver-patch: loosen/fix/document rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silvenon @ljharb @kesne @goatslacker