Adjusts DayPicker height and initializes width when DayPicker is about to be shown #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
ljharb
reviewed
Nov 22, 2016
| this.setState({ | ||
| currentMonth: nextProps.initialVisibleMonth(), | ||
| }); | ||
| if (!nextProps.hidden) { |
There was a problem hiding this comment.
i wonder if perhaps componentDidUpdate would be a better place to do this computation, since that should fire every time the component rerenders?
There was a problem hiding this comment.
My thought, especially for the height which affects the visual appearance of the calendar on opening, is that we want to do this ASAP. While there is still somewhat of a delay in growing of the height of the DayPicker, I believe it is less noticeable here than in componentDidUpdate. I'll look side-by-side but it would make sense for that to be the case.
Other than the initial load, this only needs to fire when you navigate months and I believe that is already happening in componentDidUpdate.
ljharb
approved these changes
Nov 30, 2016
majapw
force-pushed
the
maja-fix-uninitialized-width-issue
branch
from
04a6956 to
4c66b0d
Compare
This was referenced Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix #177 and also #105 and #46. Lol. Lots of dupes.
The idea is that while we use
visibility: hiddenin place ofdisplay: nonewhen hiding theDayPickerso we can measure it properly, we can't actually guarantee that some parent isn't hiding the whole thing usingdisplay: none(in some modal implementations, for instance). This alleviates the issue somewhat by doing these DOM calculations right before we show theDayPicker(which can only happen when you click on or focus on a visibleDateRangePickercomponent).@subicura does this fix your issue?
Please take a look @airbnb/webinfra!