Avoid passing false as day #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
reviewed
Feb 7, 2017
src/components/CalendarMonth.jsx
Outdated
| @@ -100,7 +100,7 @@ export default class CalendarMonth extends React.Component { | |||
| <tr key={i}> | |||
| {week.map((day, dayOfWeek) => ( | |||
| <CalendarDay | |||
| day={day} | |||
| day={day ? day : null} | |||
There was a problem hiding this comment.
Doesn't it make more sense to return null in getCalendarMonthWeeks?
There was a problem hiding this comment.
Makes sense, moved to getCalendarMonthWeeks and added specs
moonboots
force-pushed
the
fix-boolean-days
branch
from
2012ea9 to
6119d48
Compare
moonboots
force-pushed
the
fix-boolean-days
branch
from
6119d48 to
04ee39c
Compare
moonboots
force-pushed
the
fix-boolean-days
branch
from
04ee39c to
f99af7d
Compare
majapw
approved these changes
Feb 7, 2017
ljharb
reviewed
Feb 8, 2017
| describe('padding when enableOutsideDays is false', () => { | ||
| let weeksWithPadding; | ||
|
|
||
| before(() => { |
There was a problem hiding this comment.
this should use beforeEach - before means "before all" so it only runs once.
There was a problem hiding this comment.
beforeEach would work too, but here I intended the before all behavior because I'm not mutating this variable. I wrapped in a before block instead of defining up top like the other variables as a minor perf improvement to avoid running if .only(...) was used elsewhere.
There was a problem hiding this comment.
We shouldn't worry about perf in tests; before should always be avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @majapw @ljharb
Small PropType fix for my previous CalendarDay PR. In
CalendarMonth,dayisfalseinstead of a moment object for outside days, which fails PropType checks.