[iOS - Google Maps] Add onPress support for Polyline #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermepontes
changed the title
|
Any news about the merge? |
|
@guilhermepontes This looks good! Do you think you can resolve the conflicts so we can get this merged in. Conflict is from the library trying to use RCTConvert+MapKit instead of RCTConvert+AirMap |
guilhermepontes
force-pushed
the
feature/google-maps-ios-polyine-onpress
branch
from
7ab25e0 to
51c0b71
Compare
|
@christopherdro done 👍 |
christopherdro
approved these changes
May 19, 2017
jiaminglu
added a commit
to jiaminglu/react-native-maps
that referenced
this pull request
May 24, 2017
* commit '8893578ca6197d0c0a3cacf5aea9c78bfb0a4b99': v0.15.2 (react-native-maps#1352) Remove AIRGMSPolyline.h and AIRGMSPolyline.m references from AirMaps.xcodeproj (react-native-maps#1351) v0.15.1 (react-native-maps#1347) fix compile error in rn version >= 0.40 (react-native-maps#1341) Add Marker rotation for Google Maps on iOS (react-native-maps#1326) Fixing reference to AirMapsExplorer in installation docs (react-native-maps#1328) Update README: Use callback in `ref` attribute (react-native-maps#1345) [iOS] Added onPress support for Polyline on Google Maps (react-native-maps#1194) [rnpm] Fix sourceDir for Android (react-native-maps#1313) Update license date (react-native-maps#1316) Fix overlay issues in Android introduced in 0.13.1 (react-native-maps#1311) Conflicts: lib/android/googlemap/src/main/java/com/airbnb/android/react/maps/googlemap/AirGoogleMapView.java lib/android/gradle.properties lib/android/src/main/java/com/airbnb/android/react/maps/AirMapManager.java lib/components/MapPolyline.js
sorodrigo
pushed a commit
to Vizzuality/react-native-maps
that referenced
this pull request
May 26, 2017
* upstream/master: (24 commits) v0.15.2 (react-native-maps#1352) Remove AIRGMSPolyline.h and AIRGMSPolyline.m references from AirMaps.xcodeproj (react-native-maps#1351) v0.15.1 (react-native-maps#1347) fix compile error in rn version >= 0.40 (react-native-maps#1341) Add Marker rotation for Google Maps on iOS (react-native-maps#1326) Fixing reference to AirMapsExplorer in installation docs (react-native-maps#1328) Update README: Use callback in `ref` attribute (react-native-maps#1345) [iOS] Added onPress support for Polyline on Google Maps (react-native-maps#1194) [rnpm] Fix sourceDir for Android (react-native-maps#1313) Update license date (react-native-maps#1316) Fix overlay issues in Android introduced in 0.13.1 (react-native-maps#1311) v0.15.0 (react-native-maps#1305) fixing code snippet (react-native-maps#1196) small typo fixed (react-native-maps#1211) Update installation.md (react-native-maps#1226) Fixed path in `android/settings.gradle` (react-native-maps#1230) Add babelrc to npmignore (react-native-maps#1246) Update installation.md (react-native-maps#1179) Update docs to specify how to access event data (react-native-maps#1178) Update path in android installation (react-native-maps#1249) ...
j8seangel
added a commit
to Vizzuality/react-native-maps
that referenced
this pull request
May 29, 2017
…native-maps into feature/canvas-android * 'feature/canvas-android' of github.com:Vizzuality/react-native-maps: (24 commits) v0.15.2 (react-native-maps#1352) Remove AIRGMSPolyline.h and AIRGMSPolyline.m references from AirMaps.xcodeproj (react-native-maps#1351) v0.15.1 (react-native-maps#1347) fix compile error in rn version >= 0.40 (react-native-maps#1341) Add Marker rotation for Google Maps on iOS (react-native-maps#1326) Fixing reference to AirMapsExplorer in installation docs (react-native-maps#1328) Update README: Use callback in `ref` attribute (react-native-maps#1345) [iOS] Added onPress support for Polyline on Google Maps (react-native-maps#1194) [rnpm] Fix sourceDir for Android (react-native-maps#1313) Update license date (react-native-maps#1316) Fix overlay issues in Android introduced in 0.13.1 (react-native-maps#1311) v0.15.0 (react-native-maps#1305) fixing code snippet (react-native-maps#1196) small typo fixed (react-native-maps#1211) Update installation.md (react-native-maps#1226) Fixed path in `android/settings.gradle` (react-native-maps#1230) Add babelrc to npmignore (react-native-maps#1246) Update installation.md (react-native-maps#1179) Update docs to specify how to access event data (react-native-maps#1178) Update path in android installation (react-native-maps#1249) ...
pjaraherrera
pushed a commit
to pjaraherrera/react-native-maps
that referenced
this pull request
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem of not having the
onPressevent on Google Maps in iOS.