Merge Ground Overlay Support (PR-1586) #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@isener mind checking my rebased PR? (BTW thank you very much) |
|
Good work mate, I don't have time to check fully. Will do it asap on the fly |
|
@rborn frankly speaking, no. I just checked that it was building ok. Did not check the features. |
|
I'll merge and wait for the community feedback. |
|
React.PropTypes is deprecated. Every where else in this package we're using the separate package. @alvelig what version of RN were you building with? I'm pretty sure you would have noticed it failing if it were a recent version. Generally I'd recommend testing with newer versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1586, as after rebase to the current master.