Tile overlay, rebased #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| private TileOverlayOptions createTileOverlayOptions() { | ||
| TileOverlayOptions options = new TileOverlayOptions(); | ||
| options.zIndex(zIndex); | ||
| this.tileProvider = new AIRMapUrlTileProvider(256, 256, this.urlTemplate); |
There was a problem hiding this comment.
I think sizes must not be hardcoded, but used as a parameter. Because retina tiles could be 512x512 and bigger.
| { | ||
| if (!_urlTemplateSet) return; | ||
| self.tileOverlay = [[MKTileOverlay alloc] initWithURLTemplate:self.urlTemplate]; | ||
| self.tileOverlay.canReplaceMapContent = YES; |
There was a problem hiding this comment.
Here we need a way to specify the tiles size:
self.tileOverlay.tileSize = CGSizeMake(512, 512);
self.tileOverlay.maximumZ = 18;
|
@spikebrehm I think wee need to add a param for tile sizes. |
|
@alexHlebnikov good call! Would you be able to create a PR for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #143, but rebased off of latest master. There were a bunch of conflicts.
Thanks @cascadian for doing the original work!
iOS
Android
What I don't understand is how, in this example using the Stamen watercolor tiles:
The iOS tiles appear much more high-res than Android. Oh... maybe it's just a pixel density thing on the emulators? That would make sense.
cc: @christopherdro @lelandrichardson @jrichardlai