[android] Add parameter to disable the moving on marker press #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,6 +165,11 @@ public void setLoadingEnabled(AirMapView view, boolean loadingEnabled) { | |||
| view.enableMapLoading(loadingEnabled); | |||
| } | |||
|
|
|||
| @ReactProp(name="moveOnMarkerPress", defaultBoolean = true) | |||
| public void setMoveOnMarkerPress(AirMapView view, boolean moveOnPress) { | |||
There was a problem hiding this comment.
Just to clarify, should I add spaces around the = or remove it? The other methods in the file use both standards.
There was a problem hiding this comment.
space around =. I guess I missed the other props that do the same.
I think the general syntax is to have space in between. Would be great if you can adjust the others to match as well.
|
LGTM! Small nit pick comment |
|
@spikebrehm @lelandrichardson LGTM! Thoughts on getting this is? |
|
Beautiful, thank you! |
|
LMK if you need me to cut a new release for this. |
|
Would be great with the commit for react native 0.35. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS (Apple Maps) clicking a marker doesn't move the map but on Android clicking a marker causes the map to move. This PR adds a property that lets that behavior be disabled.
Test plan (on Android):
Before:
After:
