-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #470. Support legalLabelInsets on Apple Maps #840
Conversation
This will add support for `legalLabelInsets` prop on iOS with Apple Maps. Code is adapted from RN core.
Thanks! We should probably avoid |
@gilbox Yeah, let's keep it consistent. I've removed it. |
@scarlac will you be able to add an example? |
@gilbox Ah! I am assuming you mean updating the documentation. Yes, I'll get right on it tomorrow and update this PR :) |
@scarlac I was talking about adding an example in the |
@gilbox I've added an example to demonstrate the usefulness of the Let me know if there's more you need before it's ready for a merging. |
lgtm but I'd like to get a second opinion re: the async op |
thanks @scarlac ( ◠‿◠ ) |
My pleasure! 👍 |
…eact-native-maps#840) * Fixes react-native-maps#470 for iOS and Apple Maps This will add support for `legalLabelInsets` prop on iOS with Apple Maps. Code is adapted from RN core. * Pluralize updateLegalLabelInset(s) for consistency * Removed arrow notation * Added legalLabelInsets example
Fixes #470. This will add support for
legalLabelInsets
prop on iOS with Apple Maps. Code is adapted from RN core.