Config programmatic roles in the config.py (#1664)

* Config programmatic roles in the config.py, * Add sql_lab.
apache · Nov 29, 2016 · c07f0ab · c07f0ab
1 parent 1c429b2
commit c07f0ab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/superset/config.py b/superset/config.py
@@ -244,6 +244,10 @@ class CeleryConfig(object):
 # dictionary.
 JINJA_CONTEXT_ADDONS = {}
 
+# Roles that are controlled by the API / Superset and should not be changes
+# by humans.
+ROBOT_PERMISSION_ROLES = ['Public', 'Gamma', 'Alpha', 'Admin', 'sql_lab']
+
 try:
     from superset_config import *  # noqa
     print('Loaded your LOCAL configuration')

diff --git a/superset/models.py b/superset/models.py
@@ -2561,7 +2561,7 @@ class DatasourceAccessRequest(Model, AuditMixinNullable):
     datasource_id = Column(Integer)
     datasource_type = Column(String(200))
 
-    ROLES_BLACKLIST = set(['Admin', 'Alpha', 'Gamma', 'Public'])
+    ROLES_BLACKLIST = set(config.get('ROBOT_PERMISSION_ROLES', []))
 
     @property
     def cls_model(self):