Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Cleaning up CLI stdout on startup #2202

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Feb 18, 2017

on startup, FAB spits out a bunch of logging messages that aren't useful
in most cases. This shuts them down by default. They can be turned back
on with config.SILENCE_FAB = True

Also:

  • shushing a flask-cache warning around setting up a null (default) cache.
  • showing the config file that gets loaded explicitely
    After:
$ superset
Loaded your LOCAL configuration at [/Users/maxime_beauchemin/code/caravel/superset_config.pyc]
usage: superset [-?]

                {shell,version,worker,db,runserver,refresh_druid,init,load_examples,update_datasources_cache}
                ...

positional arguments:
  {shell,version,worker,db,runserver,refresh_druid,init,load_examples,update_datasources_cache}
    shell               Runs a Python shell inside Flask application context.
    load_examples       Loads a set of Slices and Dashboards and a supporting
                        dataset
    worker              Starts a Superset worker for async SQL query
                        execution.
    db                  Perform database migrations
    runserver           Starts a Superset web server
    refresh_druid       Refresh druid datasources
    init                Inits the Superset application
    version             Prints the current version number
    update_datasources_cache
                        Refresh sqllab datasources cache

optional arguments:
  -?, --help            show this help message and exit

on startup, FAB spits out a bunch of logging messages that aren't useful
in most cases. This shuts them down by default. They can be turned back
on with `config.SILENCE_FAB = True`

Also shushing a flask-cache warning around setting up a null (default) cache
@bkyryliuk
Copy link
Member

LGTM

@@ -290,3 +280,21 @@ class CeleryConfig(object):

if not CACHE_DEFAULT_TIMEOUT:
CACHE_DEFAULT_TIMEOUT = CACHE_CONFIG.get('CACHE_DEFAULT_TIMEOUT')

# Whether to bump the logging level to ERRROR on the flask_appbiulder package
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ERRROR/ERROR

s/flask_appbiulder/flask_appbuilder

@mistercrunch
Copy link
Member Author

I'll skip the typo fix here to preserve the commit SHA since I have another PR on top of this one. Will fix on top of these 2.

@mistercrunch mistercrunch merged commit ce1e18b into apache:master Feb 21, 2017
@mistercrunch mistercrunch deleted the clean_cli branch February 21, 2017 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants