explicit-any plugin fails to parse arrow function with implicit return of a literal object

[rdsedmundo]

Command: yarn ts-migrate-full ./test-project --plugin explicit-any

Input:

export const fn = ({ arg }) => {
  return {
    a: arg.map((b) => ({
      c: b.property,
    })),
  };
};

Output:

export const fn = ({
  arg
}: any) => {
  return {
    a: arg.map((b: any) => {
      c: b.property,
    }),
  };
};

The surrounding parenthesis are being removed.

[rdsedmundo]

Downgrading to 0.1.16 makes it work again. I had to force the resolution on Yarn by the way, because the main package releases the dependent packages with a caret (ˆ) in the version, so it always picks up the latest—might be something worth changing).

[rdsedmundo]

@edsrzf From my investigation I think this is related to the latest dependencies update you did, somehow it broke the logic we have for diagnostic.code=7006. Could you please have a look?

[edsrzf]

Yep, will do. Thanks for all the detail.

[edsrzf]

It looks like this was introduced when we upgraded jscodeshift in #106. Trying to figure out the appropriate fix...

[edsrzf]

Upstream issue is here: benjamn/recast#743 (recast is a jscodeshift dependency)

Two PRs claiming to fix it, unreviewed and unmerged:

• fix: parenthesizes around arrow function body returning object benjamn/recast#744
• fix: parenthesizes around arrow function body returning object  benjamn/recast#830