Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg-config file does not list libusb as a requirement #38

Open
classabbyamp opened this issue Jul 28, 2022 · 3 comments
Open

pkg-config file does not list libusb as a requirement #38

classabbyamp opened this issue Jul 28, 2022 · 3 comments

Comments

@classabbyamp
Copy link

many pkgconfig files for programs that link against libusb have a Requires.private: libusb-1.0 >= x.x.x in the .pc file. Can this be added to libairspyhf's pkgconfig file?

@touil
Copy link
Member

touil commented Jul 28, 2022

What actual problem are you trying to solve by restricting libusb versions?

@classabbyamp
Copy link
Author

classabbyamp commented Jul 28, 2022

if there's no version restriction on libusb for airspyhf, then that's fine, I was just giving an example. However, the pkgconfig file does not mention the libusb build dependency, which means that someone using the pkgconfig file for a project depending on libairspyhf would not explicitly know what the dependencies are. libairspy has this same issue.

Requires: A list of packages required by this package. The versions of these packages may be specified using the comparison operators =, <, >, <= or >=.
Requires.private: A list of private packages required by this package but not exposed to applications. The version specific rules from the Requires field also apply here.

(https://people.freedesktop.org/~dbn/pkg-config-guide.html#concepts)

@ahopper
Copy link

ahopper commented Dec 10, 2022

There does appear to be a minimum libusb version of 1.0.23 caused by the use of libusb_wrap_sys_device.
I think the use of libusb_interrupt_event_handler also requires 1.0.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants