Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown highlight breaks when adding underscore #3942

Closed
ghost opened this issue Apr 24, 2019 · 2 comments
Closed

Markdown highlight breaks when adding underscore #3942

ghost opened this issue Apr 24, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 24, 2019

Adding underscore to the markdown breaks the markdown highlighting in the editor.

Additional info:
Snapshots from Ace live demo

  1. When writing in blockquote
    image

  2. When writing in plain text
    image

Thought it does not break the resultant markdown, text written in a code span works, but highlighting breaks. It highlights as an emphasis but resulting in code span.

Expected behavior
It should not highlight as emphasis instead, code span should take more precedence.

@tessus
Copy link

tessus commented Mar 20, 2020

This is a parsing error of the hl engine (or the rules are wrong).

Italics should only be highlighted when surrounded by

  • at least one space on both sides
  • at least one space on one side and a punctuation character on the other

image

As you can see here, they are not rendered as italics.

This behavior is really annoying the only way to make text readable is to override .ace_string.ace_emphasis with the color of the standard text.

We use Ace in the project Joplin and hope this will be fixed soon.

@github-actions
Copy link

github-actions bot commented May 9, 2022

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant