Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Promise support to instanceof #52

Closed
jbottigliero opened this issue Jan 31, 2018 · 2 comments
Closed

Add Promise support to instanceof #52

jbottigliero opened this issue Jan 31, 2018 · 2 comments
Labels
enhancement

Comments

@jbottigliero
Copy link
Contributor

While working on webpack/webpack-cli#240 the need for validating a Promise came up. It looks like the only way to use instanceof to validate this constructor type is by augmenting the CONSTRUCTORS manually (similar to adding a custom constructor).

It seems like the Promise constructor could be supported in a similar manner as Buffer.

I've opened a PR proposing this update #51 – looking forward to the discussion, thanks!
@epoberezkin
Copy link
Member

#51 merged, will release.

@epoberezkin
Copy link
Member

in 3.1.0

@jbottigliero jbottigliero mentioned this issue Jan 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbottigliero @epoberezkin