Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linters are run multiple times on CI #358

Closed
akaihola opened this issue Apr 13, 2022 · 0 comments · Fixed by #361
Closed

Linters are run multiple times on CI #358

akaihola opened this issue Apr 13, 2022 · 0 comments · Fixed by #361
Assignees
@akaihola
Labels
CI
Milestone
Darker 1.5.1

Comments

@akaihola
Copy link
Owner

In the build matrix, multiple different OS / Python version configurations run the same linters:

  • on Linux/Win/macOS with Python 3.7 thru 3.10:
    • flake8 via pytest-flake8
    • isort via pytest-isort

mypy and pylint are run as part of the darker run on Linux/Win/macOS with Python 3.9 and 3.10. But we could argue that's useful duplication since it exercises the --lint functionality of Darker on different platforms.
@akaihola akaihola self-assigned this Apr 24, 2022
@akaihola akaihola added the CI label Apr 24, 2022
@akaihola akaihola added this to the 1.5.1 milestone Apr 24, 2022
@akaihola akaihola linked a pull request Apr 24, 2022 that will close this issue
Don't run duplicate linters #361
Merged
@akaihola akaihola changed the title Don't run duplicate linters on CI Linters are run multiple times on CI Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akaihola akaihola

Labels
CI
Projects
None yet
Milestone
Darker 1.5.1
Development

Successfully merging a pull request may close this issue.

Don't run duplicate linters akaihola/darker
1 participant
@akaihola