Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point out shortcomings in --lint mypy #380

Closed
3 tasks
akaihola opened this issue Aug 28, 2022 · 2 comments
Closed
3 tasks

Point out shortcomings in --lint mypy #380

akaihola opened this issue Aug 28, 2022 · 2 comments
Assignees
@akaihola
Labels
documentation Improvements or additions to documentation maybe invalid? Can't reproduce, or seems already fixed, or need more information
Milestone
Darker 2.1.1

Comments

@akaihola
Copy link
Owner

  • in README.rst, recommend against using --lint mypy
  • warn about and explain the current shortcoming (mypy errors in other lines or files than the modified line are not included)
  • possibly additionally drop other mentions of mypy

Originally posted by @akaihola in #328 (reply in thread)
@akaihola akaihola mentioned this issue Aug 28, 2022
Closed
@akaihola akaihola self-assigned this Aug 28, 2022
@akaihola akaihola added the documentation Improvements or additions to documentation label Aug 28, 2022
@akaihola akaihola added this to the 1.5.1 milestone Aug 28, 2022
@akaihola akaihola modified the milestones: 1.5.1, 1.6.0 Sep 13, 2022
@SchoolGuy SchoolGuy mentioned this issue Oct 21, 2022
Merged
@akaihola akaihola modified the milestones: 1.6.0, 1.6.1 Dec 19, 2022
@akaihola
Copy link
Owner Author

#393 will fix Mypy behavior soon, so maybe not add this after all?

@akaihola akaihola added the maybe invalid? Can't reproduce, or seems already fixed, or need more information label Dec 25, 2022
@akaihola akaihola modified the milestones: 1.6.1, 1.7.0 Dec 26, 2022
@akaihola akaihola mentioned this issue Dec 26, 2022
Merged
10 tasks
@akaihola akaihola modified the milestones: 1.7.0, 1.7.1 Feb 11, 2023
@akaihola akaihola modified the milestones: 1.7.1, 1.7.2 Feb 19, 2023
@akaihola akaihola modified the milestones: Darker 1.7.2, Darker 1.8.1 Mar 26, 2023
@akaihola
Copy link
Owner Author

#393 added baseline linting, so this is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akaihola akaihola

Labels
documentation Improvements or additions to documentation maybe invalid? Can't reproduce, or seems already fixed, or need more information
Projects
Darker and Graylint development
Archived in project
Milestone
Darker 2.1.1
Development

No branches or pull requests
1 participant
@akaihola