Vscode instructions don't work on OSX

[virtuald]

• VSCode 1.48.2
• Darker 1.1.0
• Black 20.8b1
• Python 3.7.3
• Python extension 2020.8.105045

Workspace settings:

    "python.formatting.provider": "black",
    "python.formatting.blackPath": "/home/virtuald/.virtualenvs/frc-2020/bin/darker",
    "python.formatting.blackArgs": [
        "--diff"
    ],
    "editor.formatOnSave": true,

In the output section it does look like it's running darker, but nothing happens (and there's an extra diff -- I tried removing it and it didn't fix it):

> ~/.virtualenvs/frc-2020/bin/darker --diff --diff --quiet ~/dev/frc/test/test.py.5653cc201affb899ab4952d1f891988b.tmp
cwd: ~/dev/frc/test

Changing the formatter to the original black executable does formatting as one would expect.

[akaihola]

@Carreau could you look at this issue – is there an incompatibility or a mistake in our instructions?

Maybe darker doesn't like the fact that the file name ends with .tmp instead of .py?

[shangxiao]

I noticed this issue as well… but only for files that you open "directly". If you open a folder, then open a file it works. Forgive me as I'm not a VS Code user but I just wanted to report that it does indeed 1/2 work.

I examined the output of darker --diff vs black --diff and I wonder whether it's because black seems to report the patch with absolute paths whereas darker used relative paths? 🤔

Another thing: I noticed that (somewhat obviously perhaps?) that it only formats after the file is saved?

For me:

• MacOS 10.15.7
• VSCode 1.49.3
• Darker 1.2.0
• Black 20.8b1
• Python 3.8.5

[akaihola]

black seems to report the patch with absolute paths whereas darker used relative paths

@shangxiao if I create a branch which changes Darker to report absolute paths, would you be willing to test it with VS Code?

[akaihola]

I examined the output of darker --diff vs black --diff and I wonder whether it's because black seems to report the patch with absolute paths

@shangxiao I tried black --diff with Black 20.8b1, and I see only relative paths. Do you have a different version?

[akaihola]

@shangxiao other differences between Black and Darker --diff output:

• Black displays five lines of context, Darker only three
• Black includes file modification timestamps on the --- and +++ lines, Darker doesn't

Those I could also try enabling in a branch so they could be tested with VS Code.

[akaihola]

@virtuald @shangxiao @Carreau you could try whether #84 makes any difference for VS Code.

[akaihola]

I wonder if this is the same issue as #104, and whether it still happens with Darker 1.3.0.

[akaihola]

I'll assign this to the 1.4.2 release, but since there haven't been more complaints about this since the 1.3.0 release, I think by end of February I'll conclude this isn't an issue anymore and close the issue.