-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uv work: implement oldest dependencies into pyproject.toml #810
base: master
Are you sure you want to change the base?
Conversation
@@ -24,7 +24,9 @@ jobs: | |||
uses: astral-sh/setup-uv@v3 | |||
- uses: actions/setup-python@v5 | |||
- name: Build wheel distribution | |||
run: uv build --wheel | |||
run: | | |||
uv sync --all-packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is uv sync --all-packages
needed before running uv build
?
Seems unrelated to testing with oldest dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran uv build
in this branch, and now the long description in PKG_INFO
in the source distribution contains the HTML table for contributors. This is not desired since PyPI is not able to render raw HTML (see build #2766):
Checking dist/darker-2.1.1-py3-none-any.whl: FAILED
ERROR `long_description` has syntax errors in markup and would not be
rendered on PyPI.
line 974: Warning: "raw" directive disabled.
Checking dist/darker-2.1.1.tar.gz: FAILED
ERROR `long_description` has syntax errors in markup and would not be
rendered on PyPI.
line 974: Warning: "raw" directive disabled.
When migrating from setup.cfg
to pyproject.toml
, we need ensure setup.py
still gets run, reads README.rst
, removes the contributor table, and uses the result as the long description.
The solution is to remove [tool.setuptools.dynamic]
section and the readme =
definition inside it. See this comment for details.
(This PR essentially fixes #806 which also explains the README issue.)
8b2bcd5
to
81c7fb3
Compare
Fixes #806