Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persistenceId misisng in JournalTypeConverter.unmarshal signature #22

Closed
t3hnar opened this issue Jun 21, 2015 · 2 comments
Closed

persistenceId misisng in JournalTypeConverter.unmarshal signature #22

t3hnar opened this issue Jun 21, 2015 · 2 comments

Comments

@t3hnar
Copy link
Contributor

t3hnar commented Jun 21, 2015

I'm using persistenceId to decide whether to use binary or json serialiser, however it is a bit problematic to deserialize with current JournalTypeConverter.unmarshal api.

@dnvriend
Copy link
Contributor

Hi,

I have released v1.1.6 that has the following signature for the JournalTypeConverter.unmarshal; it breaks the serialization API but now you can determine which serializer to use based on the persistenceId that will be passed to the API.

def unmarshal(value: String, persistenceId: String)(implicit serialization: Serialization): PersistentRepr

Let me know what you think and have fun!

@t3hnar
Copy link
Contributor Author

t3hnar commented Jun 22, 2015

Thx @dnvriend!

@octonato octonato added this to the invalid/not release bound milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants