Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support schema in upsert for durable store #719

Merged
merged 6 commits into from
Feb 20, 2023

Conversation

cwholmes
Copy link
Contributor

The durable state store has configuration for a schema of the durable_state table. This configuration seems to be supported for the get and delete object methods, but not for the upsert method. This PR adds support for that configuration when upserting.

This is an addition to changes in #575

@lightbend-cla-validator

Hi @cwholmes,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@patriknw patriknw merged commit dcb1115 into akka:master Feb 20, 2023
@patriknw patriknw added this to the 5.3.0 milestone Feb 20, 2023
@johanandren johanandren modified the milestones: 5.3.0, 5.2.1 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants