chore: modern Fossa workflow #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
approved these changes
Oct 24, 2022
| @@ -13,21 +13,19 @@ jobs: | |||
| steps: | |||
| - name: Checkout | |||
| uses: actions/checkout@v2 | |||
| with: | |||
| # we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
when was this needed, why not needed any more
There was a problem hiding this comment.
this is the same in all other workflows
There was a problem hiding this comment.
Right, let's keep it. Mima might bail when the last release is too many commits away.
johanandren
approved these changes
Oct 24, 2022
This was referenced Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fossa CLI installation was outdated.
Changed to
coursier/setup-actionfor the JDK and sbt installation.