Commit refreshing: fix bug from aggregating offsets #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Since #862 the commit refreshing has been broken as the internal data structure did not get updated when the commits where issued.
This bug is present in Alpakka Kafka 1.1.0.
References
#862
Background Context
Our test in
RetentionSpeccould not identify this bug as it runs against a broker that retains commits correctly. The Kafka broker bug was fixed in Kafka 2.1.0.This error was discovered by @seglo while upgrading the Kafka client to version 2.4.0.