Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mima: don't check reference connector, as it is not published #1861

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Mima: don't check reference connector, as it is not published #1861

merged 1 commit into from
Aug 7, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Aug 6, 2019

Purpose

Use the interalProject setup for the reference connector to not check Mima for it.

References

#1860

References #xxxx

Background Context

#1860 enabled Mima for the reference connector which isn't published, so it doesn't work.

@ennru ennru mentioned this pull request Aug 6, 2019
Merged
@ennru
Copy link
Member Author

ennru commented Aug 7, 2019

Failure was #1801

2m
2m approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2m 2m added this to the invalid/not release-bound milestone Aug 7, 2019
@2m 2m merged commit 8e32c59 into akka:master Aug 7, 2019
@ennru ennru deleted the no-mima-for-reference branch April 21, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
alpakka-itself
Projects
None yet
Milestone
invalid/not release-bound
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @2m