Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB: Add TransactionCanceledException #1863

Merged
merged 1 commit into from
Aug 7, 2019
Merged

DynamoDB: Add TransactionCanceledException #1863

merged 1 commit into from
Aug 7, 2019

Conversation

pulltab
Copy link
Contributor

@pulltab pulltab commented Aug 6, 2019

Purpose

TransactionCanceledException was not previously parsable, resulting in
generic AmazonDynamoDBExceptions being returned with no ability
for users to extract specifics as to why the transaction has been
canceled.

References

References #1847

Changes

  • Introduced a new shape capable of parsing TransactionCanceledExceptions.

Background Context

Given this update was so trivial, I feel there was no other approach that can be justified.

TransactionCanceledException was simply not added when transaction support was originally introduced.

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@pulltab
Copy link
Contributor Author

pulltab commented Aug 6, 2019

Note - I signed the CLA after the PR was created.

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@2m
Copy link
Contributor

2m commented Aug 7, 2019

I have rebased this PR on top of the latest master as there were some changes in master that affected CI.

@pulltab can you add the email from the commit to your GitHub profile, so CLA checker can match GitHub user that signed CLA and the committer?

Copy link
Contributor

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2m 2m added this to the 1.1.1 milestone Aug 7, 2019
@pulltab
Copy link
Contributor Author

pulltab commented Aug 7, 2019

@2m Thank you.

I added the email I used to sign the CLA to my profile. Is there anything I need to do to retrigger the check?

@2m
Copy link
Contributor

2m commented Aug 7, 2019

I re-triggered CLA checker, but the status is still the same. Note, that you need to add the email, that you used to author the commit (you can see it here: https://github.com/akka/alpakka/commit/151d471bdb386d0c20538ae6b24fc155d8671534.patch) to your GitHub profile.

@pulltab
Copy link
Contributor Author

pulltab commented Aug 7, 2019

Ah, yes, I meant to make the commit under my personal email.

Let me re-author the change such that it is using the proper email address.

TransactionCanceledException was not previously parsable, resulting in
generic AmazonDynamoDBExceptions being returned with no ability
for users to extract specifics as to why the transaction has been
canceled.
@pulltab
Copy link
Contributor Author

pulltab commented Aug 7, 2019

Ok. The commit has been amended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants