Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning with PHP 8.4 #46

Closed
acelaya opened this issue Nov 17, 2024 · 2 comments
Closed

Deprecation warning with PHP 8.4 #46

acelaya opened this issue Nov 17, 2024 · 2 comments

Comments

@acelaya
Copy link
Contributor

acelaya commented Nov 17, 2024

I have identified this deprecation warning thrown when using with PHP 8.4 RKA\Middleware\IpAddress::__construct(): Implicitly marking parameter $trustedProxies as nullable is deprecated, the explicit nullable type must be used instead.

This is the RFC where this was proposed https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

The solution implies implicitly marking parameters as nullable when they have null as default value.

I'm happy to provide a PR addressing these warnings and adding PHP 8.4 to the pipeline.

@akrabat
Copy link
Owner

akrabat commented Nov 24, 2024

Thanks for the report and fix. Not sure why you deleted your PR so quickly, but I remade and released 2.4.0.

@akrabat akrabat closed this as completed Nov 24, 2024
@acelaya
Copy link
Contributor Author

acelaya commented Nov 24, 2024

Not sure why you deleted your PR so quickly

Oh! Sorry, that was unintentional. I think I deleted the source branch from my fork by mistake.

Thanks for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants