code clean up (dotnet#1917)

* moved local functions moved local functions to top for readability and fixed missing semicolon local function at the end tslint exception for chai * use genral tslint chai rules * fix path to custom chai rules * revert type package versions * simplify gulp file * force chai types to 4.0.8
akshita31 · Dec 11, 2017 · 8c24f9d · 8c24f9d
1 parent ee50939
commit 8c24f9d
Show file tree

Hide file tree

Showing 8 changed files with 179 additions and 172 deletions.
diff --git a/.gitignore b/.gitignore
@@ -14,3 +14,5 @@ obj/
 bin/
 test/**/.vscode
 .logs/
+
+\.DS_Store
diff --git a/gulpfile.js b/gulpfile.js
@@ -170,7 +170,7 @@ gulp.task('tslint', () => {
     gulp.src(allTypeScript)
         .pipe(tslint({
             program: require('tslint').Linter.createProgram("./tsconfig.json"),
-            rulesDirectory: "node_modules/tslint-microsoft-contrib"
+            configuration: "./tslint.json"
         }))
         .pipe(tslint.report(lintReporter, {
             summarizeFailureOutput: false,