Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File issues with HighlightJS #58

Open
3 tasks
alexeyinkin opened this issue Apr 11, 2023 · 0 comments
Open
3 tasks

File issues with HighlightJS #58

alexeyinkin opened this issue Apr 11, 2023 · 0 comments

Comments

@alexeyinkin
Copy link
Contributor

alexeyinkin commented Apr 11, 2023

Some things in HighlightJS make the porting harder for us. We should file issues for them to simplify that because it will benefit their project as well as ours.

We should file them when we publish our package with all languages working so we can refer to it when justifying the changes for them. This will result in a higher chance for them to land. Until then accumulating these changes here:

  • className: "" can be used instead of className: null for "explicit null" that overwrites other values.
  • No TypeScript.
  • Some languages do not have a name (TODO: list them here).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant