Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The watch attribute doesn't work for complex objects #50

Open
jdmarsh opened this issue Jan 9, 2017 · 1 comment
Open

The watch attribute doesn't work for complex objects #50

jdmarsh opened this issue Jan 9, 2017 · 1 comment

Comments

@jdmarsh
Copy link
Contributor

jdmarsh commented Jan 9, 2017

When using a complex object inside the watch attribute, changes don't get tracked. Suggest finding a suitable case where the third objectEquality argument should be set for $scope.$watch('rows',....
@alalonde
Copy link
Owner

alalonde commented Jan 9, 2017

Seems like a reasonable configuration. Could you put together a PR with an additional @watchOptions input with values shallow, collection, and deep ? Would that suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdmarsh @alalonde