Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heimilisföng í "fleirtölu" beygjast ekki rétt #21

Open
oddsson opened this issue Jan 3, 2025 · 2 comments
Open

Heimilisföng í "fleirtölu" beygjast ekki rétt #21

oddsson opened this issue Jan 3, 2025 · 2 comments

Comments

@oddsson
Copy link

oddsson commented Jan 3, 2025

Heimilisföng sem heita "fleirtölu" nafni, t.d. Glaðheimar, Álfheimar, etc. fallbeygjast ekki rétt.

Sjá nánar https://playcode.io/2210671

@alexharri
Copy link
Owner

alexharri commented Jan 3, 2025

Thanks for the report! This is an interesting case.

The full data for Álfheimar in word-cases.csv looks like so:

Álfheimar;248582;kk;bær;1;;;;V;Álfheimum;ÞGFFT;1;;;
Álfheimar;248582;kk;bær;1;;;;V;Álfheima;ÞFFT;1;;;
Álfheimar;248582;kk;bær;1;;;;V;Álfheima;EFFT;1;;;
Álfheimar;248582;kk;bær;1;;;;V;Álfheimar;NFFT;1;;;

The library currently ignores all plural cases (this is the code that filters out the data in word-cases.csv):

for (const line of lines) {
  // ...

  if (isDefiniteArticle(rawName.case) || isCasePlural(rawName.case)) {
    continue; // Ignore case
  }

  // ...
}

We'll have to update Beygla to use the plural cases if the singular case is not available in the data.

I don't have much time to tackle this now (lots of personal things going on and finishing up a new post for alexharri.com). I may have some time in 2-4 weeks, but may take a bit longer to get to this (you can try creating a PR if you're in a rush to get this fixed!).

@oddsson
Copy link
Author

oddsson commented Jan 6, 2025

Thanks for the speedy reply. We are not in a huge rush to get this fixed. I probably won't have time myself to look into this, but will try my best to carve out a minute or two sometime ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants