fix(localizecount): allow localized string for count in MenuSelect (#657

) * fix(localizecount): allow localized string for count in MenuSelect * Removes potentially confusing example * Avoids modifying an object inside a map
algolia · Nov 27, 2017 · 67ebd34 · 67ebd34
1 parent d473dab
commit 67ebd34
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/packages/react-instantsearch/src/components/MenuSelect.js b/packages/react-instantsearch/src/components/MenuSelect.js
@@ -16,7 +16,10 @@ class MenuSelect extends Component {
       PropTypes.shape({
         label: PropTypes.string.isRequired,
         value: PropTypes.string.isRequired,
-        count: PropTypes.number.isRequired,
+        count: PropTypes.oneOfType([
+          PropTypes.number.isRequired,
+          PropTypes.string.isRequired,
+        ]),
         isRefined: PropTypes.bool.isRequired,
       })
     ),

diff --git a/stories/MenuSelect.stories.js b/stories/MenuSelect.stories.js
@@ -105,4 +105,25 @@ stories
       displayName,
       filterProps,
     }
+  )
+  .addWithJSX(
+    'with localized count',
+    () => (
+      <WrapWithHits linkedStoryGroup="MenuSelect">
+        <MenuSelect
+          attributeName="category"
+          defaultRefinement={text('defaultSelectedItem', 'Bathroom')}
+          transformItems={items =>
+            items.map(({ count, ...item }) => ({
+              ...item,
+              count: (count + 1000).toLocaleString(),
+            }))
+          }
+        />
+      </WrapWithHits>
+    ),
+    {
+      displayName,
+      filterProps,
+    }
   );