This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
HeirachialMenu empty array parent--item #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is more context in AlgoliaPartners#ps-digital8 channel.  The bug happens when a product is in a level 1 category and a level 2 category.
|
Deploy preview for react-instantsearch ready! Built with commit 829cb24 https://deploy-preview-1459--react-instantsearch.netlify.com |
|
This probably needs a new test to show the behaviour this fixes, WDYT? Thanks for your contribution though! ❤️ Also linting is crying because I think you need to write it on more lines or something |
samouss
pushed a commit
that referenced
this pull request
Aug 7, 2018
samouss
added a commit
that referenced
this pull request
Aug 7, 2018
* fix(List): remove class parent when items is empty * fix(List): empty array parent--item (#1459) * fix(List): rename variable isItemHasChildren to itemHasChildren
samouss
added a commit
that referenced
this pull request
Aug 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more context in AlgoliaPartners#ps-digital8 channel.
The bug happens when a product is in a level 1 category and a level 2 category.