-
Notifications
You must be signed in to change notification settings - Fork 386
[prop-types] Allow object
as type for root.Root
(Fixes #1446)
#1461
Conversation
Deploy preview for react-instantsearch ready! Built with commit ebca14c https://deploy-preview-1461--react-instantsearch.netlify.com |
Thanks, seems to be a long list now, I wonder if what we're using this for satisfies |
Tried it out quickly and it seems like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct, but leaving it up to @samouss (currently on holiday) to validate and merge. Thanks a lot!
Thanks for the fix, I will merge it as it is. There is an ongoing discussion to support |
Thanks a lot! |
Probably beginning of next week. |
Summary
Removes two warnings you get in React Native 0.56.
now uses React.forwardRef() (exact commit in react-native 0.56: facebook/react-native@3e534b9)
Therefore:
This PR adds support for that.
Result
Two warnings disappear.
Fixes #1446