This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat: InstantSearch root props #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 20e9e55 |
samouss
force-pushed
the
feature/root-props
branch
from
ba17ac3 to
20e9e55
Compare
|
Did it push to NPM? It seems not don't have effect |
|
Nope it’s not released yet, it will be published today or tomorrow. |
samouss
added a commit
that referenced
this pull request
Jan 3, 2018
<a name="4.4.0"></a> * **createInstantSearch:** remove the client from the Snapshot ([#749](#749)) ([700d8f4](700d8f4)) * refresh cache memory leak example ([#784](#784)) ([cf228ac](cf228ac)) * **stories:** rename InstantSearch to <InstantSearch> ([#789](#789)) ([05efda5](05efda5)) * InstantSearch root props ([#770](#770)) ([2d458f8](2d458f8))
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #285
Enable the possibility to pass custom
rootprops to InstantSearch. Don't introduce any breaking change, since we use the root ofcreateInstantSearchasdefaultProps.Result
The following example is with React Native, when we don't pass
flex: 1to InstantSearch the list is crop before the end.Before
After