fix: refresh cache memory leak example #784
Conversation
samouss
force-pushed
the
fix/refresh-cache-memory-leak-example
branch
from
d316bf7 to
6202bc6
Compare
|
Deploy preview ready! Built with commit 9f89076 |
samouss
force-pushed
the
fix/refresh-cache-memory-leak-example
branch
from
6202bc6 to
9f89076
Compare
| @@ -82,7 +82,11 @@ class App extends Component { | |||
| } | |||
|
|
|||
| componentDidMount() { | |||
| setInterval(() => this.setState({ refresh: true }), 5000); | |||
| this.interval = setInterval(() => this.setState({ refresh: true }), 5000); | |||
There was a problem hiding this comment.
WDYT of setting line length in markdown files to something like 60? I prefer having shorter lines when reading something in a post, rather than while writing code
There was a problem hiding this comment.
Agree, I'm looking for something like that yesterday 🙂
There was a problem hiding this comment.
I think we'll need two prettier configs for that, not sure if it's possible already 🤔
There was a problem hiding this comment.
I think we can, printWidth also handle markdown by default.
There was a problem hiding this comment.
I meant that we can't have js: { printWidth: 80 }, md: { printWidth: 55 } IIRC, but would be good to add
There was a problem hiding this comment.
Ah ok. Yep would be great to support this kind of configuration!
<a name="4.4.0"></a> * **createInstantSearch:** remove the client from the Snapshot ([#749](#749)) ([700d8f4](700d8f4)) * refresh cache memory leak example ([#784](#784)) ([cf228ac](cf228ac)) * **stories:** rename InstantSearch to <InstantSearch> ([#789](#789)) ([05efda5](05efda5)) * InstantSearch root props ([#770](#770)) ([2d458f8](2d458f8))
Summary
Clear the interval on component
willUnmount.