Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if an AlograndClient connects to algod in devmode don't cache params #273

Open
joe-p opened this issue May 2, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@joe-p
Copy link
Contributor

joe-p commented May 2, 2024

Problem

By default the AlgorandClient will cache SuggestedParams. Given the short default validity window this can result in transactions being sent outside the lastValid if multiple transactions are sent within a short period of time.

Solution

If the algod the client is connecting to is in devmode don't cache the suggestedParams

Proposal

When the suggestedParams are retrieved for the first time, also check if the network is in devmode

Pros and Cons

This allows us to keep the suggestedParams in the txns themselves the same while fixing the problem for devmode.

Dependencies

N/A

@robdmoore
Copy link
Contributor

Makes sense to me!

@robdmoore robdmoore added the enhancement New feature or request label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants