Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure telemetry #109

Open
wants to merge 1 commit into
base: v1.4.0
Choose a base branch
from
Open

feat: configure telemetry #109

wants to merge 1 commit into from

Conversation

PhearZero
Copy link
Member

ℹ Overview

  • adds configure telemetry command

📝 Related Issues

✅ Acceptance:

  • Pre-commit checks pass

@PhearZero PhearZero added this to the Milestone 2 milestone Jan 16, 2025
@PhearZero PhearZero self-assigned this Jan 16, 2025
@PhearZero PhearZero linked an issue Jan 16, 2025 that may be closed by this pull request
✨ Configure telemetry #108
Open
@PhearZero PhearZero changed the base branch from main to v1.2.0 January 20, 2025 17:46
@PhearZero PhearZero requested a review from tasosbit January 20, 2025 18:15
tasosbit
tasosbit requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@tasosbit tasosbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to a top level command. See DM

Base automatically changed from v1.2.0 to main January 23, 2025 11:47
@PhearZero PhearZero changed the base branch from main to v1.4.0 February 13, 2025 19:52
@PhearZero PhearZero marked this pull request as draft February 13, 2025 21:04
@PhearZero PhearZero force-pushed the feat/configure-telemetry branch from 1e91be6 to dbeeb03 Compare February 14, 2025 02:40
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 14, 2025 •
edited
Loading

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: 68f0693
Status: ✅  Deploy successful!
Preview URL: https://4e245e57.nodekit-run.pages.dev
Branch Preview URL: https://feat-configure-telemetry.nodekit-run.pages.dev

View logs

@PhearZero PhearZero marked this pull request as ready for review February 14, 2025 02:41
@PhearZero PhearZero force-pushed the feat/configure-telemetry branch from dbeeb03 to 68f0693 Compare February 14, 2025 02:48
@PhearZero PhearZero requested a review from tasosbit February 14, 2025 02:49
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.80282% with 259 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.4.0@5459822). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/configure/telemetry.go 10.29% 61 Missing ⚠️
internal/algod/telemetry/logging.go 0.00% 45 Missing ⚠️
cmd/telemetry/status.go 0.00% 35 Missing ⚠️
cmd/telemetry/disable/nodely.go 0.00% 28 Missing ⚠️
cmd/telemetry/enable/nodely.go 0.00% 28 Missing ⚠️
ui/prompt/model.go 0.00% 24 Missing ⚠️
internal/algod/utils/utils.go 23.80% 14 Missing and 2 partials ⚠️
cmd/utils/prompt.go 0.00% 14 Missing ⚠️
cmd/utils/utils.go 0.00% 5 Missing ⚠️
cmd/debug.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             v1.4.0     #109   +/-   ##
=========================================
  Coverage          ?   42.35%           
=========================================
  Files             ?       86           
  Lines             ?     6724           
  Branches          ?        0           
=========================================
  Hits              ?     2848           
  Misses            ?     3643           
  Partials          ?      233

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhearZero
Copy link
Member Author

PhearZero commented Feb 14, 2025 •
edited
Loading

@tasosbit This still has rough edges but should be enough to see if the structure is the right fit. Will do a cleanup pass if this looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasosbit tasosbit Awaiting requested review from tasosbit

Assignees

@PhearZero PhearZero

Labels
feature
Projects
None yet
Milestone
Milestone 2
Development

Successfully merging this pull request may close these issues.

✨ Configure telemetry
2 participants
@PhearZero @tasosbit