feat: participation key integrity hash #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ui/modal/testdata/Test_Snapshot/InfoModal.golden # ui/modals/info/testdata/Test_Snapshot/Visible.golden
Deploying nodekit-run with
|
| Latest commit: |
9d991d1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7b3885c1.nodekit-run.pages.dev |
| Branch Preview URL: | https://feat-implement-partkey-integ.nodekit-run.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
===========================================
- Coverage 47.32% 35.61% -11.71%
===========================================
Files 75 78 +3
Lines 5881 6230 +349
===========================================
- Hits 2783 2219 -564
- Misses 2891 3902 +1011
+ Partials 207 109 -98 ☔ View full report in Codecov by Sentry. |
|
This looks good but we'll park it until ARC-81 is updated with network and offline spec |
It's already live in the URL service, I don't see the benefit on keeping this ticket alive when we can create a new one if the spec changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ Overview
📝 Related Issues
✅ Acceptance: