Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use Nacos configuration information correctly when configuring the nacos endpoint #3379

Closed
huhongjie2014 opened this issue Jul 12, 2023 · 2 comments · May be fixed by #3380
Closed

Unable to use Nacos configuration information correctly when configuring the nacos endpoint #3379

huhongjie2014 opened this issue Jul 12, 2023 · 2 comments · May be fixed by #3380
Labels
stale

Comments

@huhongjie2014
Copy link

Which Component
spring-cloud-alibaba-sentinel-datasource 2021.0.5.0

Describe the bug
Unable to use Nacos configuration information correctly when configuring the nacos endpoint

When I use the following configuration, please note that I am using the nacos endpoint.

spring.cloud.sentinel.datasource.flow_rule_ds.nacos.endpoint=localhost:8080
spring.cloud.sentinel.datasource.flow_rule_ds.nacos.context-path=/nacos
spring.cloud.sentinel.datasource.flow_rule_ds.nacos.cluster-name=default
spring.cloud.sentinel.datasource.flow_rule_ds.nacos.namespace=
spring.cloud.sentinel.datasource.flow_rule_ds.nacos.username=nacos
spring.cloud.sentinel.datasource.flow_rule_ds.nacos.password=nacos
spring.cloud.sentinel.datasource.flow_rule_ds.nacos.data-id=gateway-service_flow_rule
spring.cloud.sentinel.datasource.flow_rule_ds.nacos.group-id=default
spring.cloud.sentinel.datasource.flow_rule_ds.nacos.data-type=json
spring.cloud.sentinel.datasource.flow_rule_ds.nacos.rule-type=gw-flow

But when creating the configService, the default serverAddr value is used.
截屏2023-07-12 下午9 19 19

After analyzing the source code, I found the bug code and will submit a PR to fix it.
截屏2023-07-12 下午9 21 51

Simplest demo

To Reproduce

Expected behavior
Create configService with the correct nacos configuration

Screenshots

Additional context
huhongjie2014 added a commit to huhongjie2014/spring-cloud-alibaba that referenced this issue Jul 12, 2023
@huhongjie2014
[ISSUE alibaba#3379]Unable to use Nacos configuration information cor…
0f44491 
…rectly when configuring the nacos endpoint alibaba#3379
@huhongjie2014 huhongjie2014 mentioned this issue Jul 12, 2023
Open
@github-actions
Copy link

This issue has been open 30 days with no activity. This will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 11, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity.If you think this should still be open, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for your interest and contribution to the Sping Cloud Alibaba Community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
1 participant
@huhongjie2014