Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spring cloud bus default environment initialization error #2785

Open
wants to merge 2 commits into
base: 2021.x
Choose a base branch
from

Conversation

pumbf
Copy link

@pumbf pumbf commented Sep 16, 2022

Describe what this PR does / why we need it

In 2021.x branch, spring-cloud-starter-stream-rocketmq has been refactored.However, the bus is not adapted to the new properties. Lead consumption group mode is CLUSTERING but not BROADCASTING.

Does this pull request fix one issue?

NONE

Describe how you did it

change the spring-cloud-starter-stream-rocketmq EnvironmentPostProcessor

Describe how to verify it

Open two customers, see if it is possible to receive remoteEvent

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2022

CLA assistant check
All committers have signed the CLA.

@steverao
Copy link
Collaborator

Please explain more about why we need to modify to BROADCASTING.

@pumbf
Copy link
Author

pumbf commented Sep 25, 2022

Spring Cloud Bus links nodes of a distributed system with a lightweight message broker. This can then be used to broadcast state changes (e.g. configuration changes) or other management instructions. that;s mean all node need to receive message. At the same time, the automatic configuration of the old version also set the mode to BROADCASTING.
eg:

String broadcastingPropertyName = createRocketMQPropertyName(INPUT,"broadcasting");
source.put(broadcastingPropertyName, "true");

So the main problem of spring cloud bus is that the new version does not synchronize the stream configuration changes, resulting in the inability to set the correct mode

@pumbf
Copy link
Author

pumbf commented Sep 28, 2022

@steverao Can this be explained?

@laizuan
Copy link

laizuan commented Mar 30, 2023

2022.x 版本也存在这个问题,新版本中 broadcasting 属性已经不生效了,需要配置messageModel

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants