#2862 improve seata beanPostProcessor order #2875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
李壮壮 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
|
||
| /** | ||
| * @author xiaojing | ||
| */ | ||
| public class SeataBeanPostProcessor implements BeanPostProcessor { | ||
| public class SeataBeanPostProcessor implements BeanPostProcessor, Ordered { |
There was a problem hiding this comment.
我们遇到的issue
https://q1rp72ja5q.feishu.cn/docx/EGqBd6GGboiFi4xyPxFcdy6rnwG
原因可以描述为：业务通过A开头的后置处理器间接实例化了FeignHttpClient，导致FeignHttpClient不会被seataBeanPostProcessor代理，这样的话FeignSeataClient就不生效，在feign调用中xid无法透传导致全局事务割裂。
因此建议可以提高下SeataBeanPostProcessor的优先级
jasondeng1997
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
SeataBeanPostProcessor had better has a higher init order, for fare some beans be initialized early along with some business beanPostProcessor, in that situation, this bean will not be proxyed by Seata like SeataFeignClient.
Does this pull request fix one issue?
Fixed #2862