fix bug: deserialization of chinese encoding characters in xml/yml would be incorrect #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
nacos config center 中配置xml/yml，包含中文字符。
app启动参数配置了-Dfile.encoding=gb18030时，启动报错。
当-Dfile.encoding=utf-8时，启动正常。
Does this pull request fix one issue?
NONE
Describe how you did it
在 NacosDataParserHandler getBytes时，指定UTF-8编码
Describe how to verify it
复现
2.项目启动参数配置：-Dfile.encoding=gb18030
Special notes for reviews
目前我没想到有更好的方法修复它，你们可以自己探索其它的方法。这个问题值得关注一下。
hope this PR will be help.