-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGL support #30
Comments
@michaeltmiller I don't see why that shouldn't be supported, so I'd be happy to look into it if you could provide some steps to replicate. Also, is this something that affects |
This issue can probably be closed as I've found a workaround. Copying the swiftshader binaries ( |
Thanks for the feedback @michaeltmiller, I compressed these SOs with Brotli and they amount to 981K:
Do you think it would be worthwhile shipping these and adding a helper method to enable WebGL support? |
Related: puppeteer/puppeteer#1260 |
Absolutely! That would simply our use case moving forward. Looking around the web it seems like it's a problem others are running into as well, so adding support with minimal configuration sounds like a pretty big win to me. Especially if the added overhead is that small for users that don't require it. |
It would be nice to have support for WebGL ! |
@michaeltmiller @TimotheeJeannin Out of the box support for WebGL been released on 1.15.0. Let me know if you face any issues. |
Working on my side. :) Thank you! |
@alixaxel I'm trying to create a PDF with v10.1.0 on lambda with preserveDrawingBuffer in the mapbox map, though still, the map is empty, not sure why here are my chrome args
Basically the default args, any steps that might be useful for debugging what's going wrong? |
I'm attempting to use this binary to create PDFs from pages that include WebGL canvas elements created by Mapbox. Basically I'm wondering if this should this work out of the box with the default flags, or different set of flags and/or a custom built binary will be necessary(to enable something like swiftshader).
With version
1.14.0
and the default args exposed by this package, and visiting somewhere like:https://docs.mapbox.com/mapbox-gl-js/example/simple-map/
or
http://mapbox.github.io/mapbox-gl-supported/diagnostics.html
and attempting to generate a PDF results in blank spots in the PDF.
If this is something you think should be supported, then I can provide a more fleshed out reproducer.
The text was updated successfully, but these errors were encountered: